New chromium.perf.fyi bots! Mac Retina and Android Galaxy S5.

New chromium.perf.fyi bots! Mac Retina and Android Galaxy S5.

BUG=609302, 612586
Committed: https://chromium.googlesource.com/chromium/tools/build/+/95038b7bf9bd4525e1cff0e011876f01a275be8c

[aiolos (Not reviewing), 2016-05-27 16:26:37]

The CQ bit was checked by aiolos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-27 16:26:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018003002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018003002/1

[commit-bot: I haz the power, 2016-05-27 16:26:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 16:26:46]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[jbudorick, 2016-05-27 16:30:43]

jbudorick@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2016-05-27 16:30:44]

lgtm stamp

[aiolos (Not reviewing), 2016-05-27 16:31:22]

The CQ bit was checked by aiolos@chromium.org

[commit-bot: I haz the power, 2016-05-27 16:31:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018003002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018003002/1

[commit-bot: I haz the power, 2016-05-27 16:38:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 16:38:57]

Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[aiolos (Not reviewing), 2016-05-27 19:50:12]

The CQ bit was checked by aiolos@chromium.org

[aiolos (Not reviewing), 2016-05-27 19:50:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2018003002/#ps20001
(title: "Fix expectations.")

[commit-bot: I haz the power, 2016-05-27 19:50:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018003002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018003002/20001

[commit-bot: I haz the power, 2016-05-27 19:57:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 19:57:52]

Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[fmeawad, 2016-05-27 20:04:42]

fmeawad@chromium.org changed reviewers:
+ fmeawad@chromium.org

[fmeawad, 2016-05-27 20:04:43]

https://codereview.chromium.org/2018003002/diff/20001/masters/master.chromium...
File masters/master.chromium.perf.fyi/master.cfg (right):

https://codereview.chromium.org/2018003002/diff/20001/masters/master.chromium...
masters/master.chromium.perf.fyi/master.cfg:152: })
There is only a windows builder, no mac or android builders, the tester will not
get triggered

https://codereview.chromium.org/2018003002/diff/20001/masters/master.chromium...
masters/master.chromium.perf.fyi/master.cfg:166: })
ditto

[fmeawad, 2016-05-27 20:54:09]

LGTM.

Going through the CL, I think my earlier concern about the triggers might not be
valid, the CL is trying to trigger builds from one master to another. I am happy
to give it a try.

Inlined comments are optional nits, feel free to ignore.

https://codereview.chromium.org/2018003002/diff/20001/masters/master.chromium...
File masters/master.chromium.perf.fyi/master.cfg (right):

https://codereview.chromium.org/2018003002/diff/20001/masters/master.chromium...
masters/master.chromium.perf.fyi/master.cfg:148: 'name': 'Android Galaxy S5 Perf
(1)',
I do not think it should have "(1)", it should be added if we add more, which I
do not think we will do on the FYI bots.

https://codereview.chromium.org/2018003002/diff/20001/masters/master.chromium...
File masters/master.chromium.perf.fyi/slaves.cfg (right):

https://codereview.chromium.org/2018003002/diff/20001/masters/master.chromium...
masters/master.chromium.perf.fyi/slaves.cfg:22: 'builder': 'Android Galaxy S5
Perf (1)',
Remove "(1)"

[aiolos (Not reviewing), 2016-05-27 20:57:48]

On 2016/05/27 20:54:09, fmeawad wrote:
> LGTM.
> 
> Going through the CL, I think my earlier concern about the triggers might not
be
> valid, the CL is trying to trigger builds from one master to another. I am
happy
> to give it a try.
> 
> Inlined comments are optional nits, feel free to ignore.
> 
>
https://codereview.chromium.org/2018003002/diff/20001/masters/master.chromium...
> File masters/master.chromium.perf.fyi/master.cfg (right):
> 
>
https://codereview.chromium.org/2018003002/diff/20001/masters/master.chromium...
> masters/master.chromium.perf.fyi/master.cfg:148: 'name': 'Android Galaxy S5
Perf
> (1)',
> I do not think it should have "(1)", it should be added if we add more, which
I
> do not think we will do on the FYI bots.
> 
>
https://codereview.chromium.org/2018003002/diff/20001/masters/master.chromium...
> File masters/master.chromium.perf.fyi/slaves.cfg (right):
> 
>
https://codereview.chromium.org/2018003002/diff/20001/masters/master.chromium...
> masters/master.chromium.perf.fyi/slaves.cfg:22: 'builder': 'Android Galaxy S5
> Perf (1)',
> Remove "(1)"

I'm going to ignore for now, since I think Dave did it for consistency reasons.
We can always change it next week after he gets back.

[aiolos (Not reviewing), 2016-05-27 20:57:52]

The CQ bit was checked by aiolos@chromium.org

[commit-bot: I haz the power, 2016-05-27 20:57:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018003002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018003002/20001

[commit-bot: I haz the power, 2016-05-27 21:01:59]

Description was changed from

==========
New chromium.perf.fyi bots! Mac Retina and Android Galaxy S5.

BUG=609302, 612586
==========

to

==========
New chromium.perf.fyi bots! Mac Retina and Android Galaxy S5.

BUG=609302, 612586

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/95038b7bf9bd4525e1cf...
==========

[commit-bot: I haz the power, 2016-05-27 21:02:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/95038b7bf9bd4525e1cf...