Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

Issue 2017963003: Upstream: ChildProcessLauncher connects renderer processes of WebAPKs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
index 9df61cb7740bb09a2fcd1582a13624f765bcec5f..6e16fd5a831f14dcae250ac16c582f3796bc31ae 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
@@ -114,15 +114,14 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
private Intent createServiceBindIntent() {
Intent intent = new Intent();
- if (mCreationParams != null) {
- mCreationParams.addIntentExtras(intent);
- }
+ mCreationParams.addIntentExtras(intent);
+
intent.setComponent(mServiceName);
return intent;
}
public ChildServiceConnection(int bindFlags, boolean needsExtraBindFlags) {
- if (needsExtraBindFlags && mCreationParams != null) {
+ if (needsExtraBindFlags) {
bindFlags = mCreationParams.addExtraBindFlags(bindFlags);
}
mBindFlags = bindFlags;
@@ -220,9 +219,8 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
mInSandbox = inSandbox;
mDeathCallback = deathCallback;
mServiceClass = serviceClass;
- String packageName =
- creationParams != null ? creationParams.getPackageName() : context.getPackageName();
- mServiceName = new ComponentName(packageName, mServiceClass.getName() + mServiceNumber);
+ mServiceName = new ComponentName(
+ creationParams.getPackageName(), mServiceClass.getName() + mServiceNumber);
mLinkerParams = chromiumLinkerParams;
mAlwaysInForeground = alwaysInForeground;
mCreationParams = creationParams;
@@ -271,6 +269,11 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
}
@Override
+ public ChildProcessCreationParams getCreationParams() {
+ return mCreationParams;
+ }
+
+ @Override
public IChildProcessService getService() {
synchronized (mLock) {
return mService;

Powered by Google App Engine
This is Rietveld 408576698