Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2017963002: [Sync] Remove DeviceInfoModelTypeController. (Closed)

Created:
4 years, 6 months ago by maxbogue
Modified:
4 years, 6 months ago
Reviewers:
pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Remove DeviceInfoModelTypeController. It is unnecessary; for USS the DTC's are generic and we can just use the UIModelTypeController. BUG= Committed: https://crrev.com/77d37fa5e6239339c8d6acf8155f2e26415542c3 Cr-Commit-Position: refs/heads/master@{#396900}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -72 lines) Patch
M components/browser_sync/browser/profile_sync_components_factory_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/sync_driver.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync_driver/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D components/sync_driver/device_info_model_type_controller.h View 1 chunk +0 lines, -37 lines 0 comments Download
D components/sync_driver/device_info_model_type_controller.cc View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
maxbogue
Pavel, PTAL!
4 years, 6 months ago (2016-05-30 16:01:20 UTC) #2
pavely
lgtm
4 years, 6 months ago (2016-05-31 17:34:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017963002/1
4 years, 6 months ago (2016-05-31 18:15:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 19:47:25 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 20:44:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77d37fa5e6239339c8d6acf8155f2e26415542c3
Cr-Commit-Position: refs/heads/master@{#396900}

Powered by Google App Engine
This is Rietveld 408576698