Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 201793003: Fix WebKit and Mozilla test expectations (Closed)

Created:
6 years, 9 months ago by rossberg
Modified:
6 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Fix WebKit and Mozilla test expectations R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19985

Patch Set 1 #

Total comments: 2

Patch Set 2 : Missing change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -21 lines) Patch
M test/mozilla/mozilla.status View 1 chunk +6 lines, -0 lines 0 comments Download
M test/webkit/fast/js/kde/exception_propagation.js View 1 chunk +0 lines, -20 lines 0 comments Download
M test/webkit/fast/js/kde/exception_propagation-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
rossberg
6 years, 9 months ago (2014-03-17 11:47:53 UTC) #1
Michael Starzinger
https://codereview.chromium.org/201793003/diff/1/test/webkit/fast/js/kde/exception_propagation.js File test/webkit/fast/js/kde/exception_propagation.js (left): https://codereview.chromium.org/201793003/diff/1/test/webkit/fast/js/kde/exception_propagation.js#oldcode405 test/webkit/fast/js/kde/exception_propagation.js:405: var forin_test_obj = new Object(); Better adapt the expected ...
6 years, 9 months ago (2014-03-17 11:50:34 UTC) #2
Michael Starzinger
LGTM (once comment is addressed).
6 years, 9 months ago (2014-03-17 11:51:01 UTC) #3
rossberg
https://codereview.chromium.org/201793003/diff/1/test/webkit/fast/js/kde/exception_propagation.js File test/webkit/fast/js/kde/exception_propagation.js (left): https://codereview.chromium.org/201793003/diff/1/test/webkit/fast/js/kde/exception_propagation.js#oldcode405 test/webkit/fast/js/kde/exception_propagation.js:405: var forin_test_obj = new Object(); On 2014/03/17 11:50:35, Michael ...
6 years, 9 months ago (2014-03-17 12:00:15 UTC) #4
rossberg
6 years, 9 months ago (2014-03-17 12:00:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r19985.

Powered by Google App Engine
This is Rietveld 408576698