Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 201793002: Revert of Allow frames to be free'd even for static images (Closed)

Created:
6 years, 9 months ago by fs
Modified:
6 years, 9 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Allow frames to be free'd even for static images (https://codereview.chromium.org/136503002/) Reason for revert: Diagnosing issue 350653. Original issue's description: > Allow frames to be free'd even for static images > > r151702 added limit for pruning in ImageDecoded::clearCacheExceptFrame, > which would disallow pruning single-frame/static images altogether. > > Allow such images to be pruned in their entirety by dropping the > condition for <= 1 frames - the for-loop will handle the kNotFound case. > > (Also related is r156651, which re-added the destroyAll flag.) > > Modify the ImageFrameGeneratorTest.frameHasAlpha unittest to use frame 0 > instead of frame 1, to avoid clearing frame 1 (MockImageDecoder > maps all indices to frame 0.) > > R=hclam@chromium.org,pkasting@chromium.org,senorblanco@chromium.org > BUG=302851 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165127 TBR=hclam@chromium.org,pkasting@chromium.org,senorblanco@chromium.org,jochen@chromium.org NOTREECHECKS=true NOTRY=true BUG=302851 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M Source/platform/graphics/ImageFrameGeneratorTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/image-decoders/ImageDecoder.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/platform/image-decoders/ImageDecoderTest.cpp View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
fs
Created Revert of Allow frames to be free'd even for static images
6 years, 9 months ago (2014-03-17 11:47:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/201793002/1
6 years, 9 months ago (2014-03-17 11:47:39 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-17 11:47:59 UTC) #3
Message was sent while issue was closed.
Change committed as 169347

Powered by Google App Engine
This is Rietveld 408576698