Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: tests/compiler/dart2js/serialization/model_test.dart

Issue 2017903002: Improve equivalence testing of unnamed mixin applications. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/serialization/model_test.dart
diff --git a/tests/compiler/dart2js/serialization/model_test.dart b/tests/compiler/dart2js/serialization/model_test.dart
index dd86acd1cb76e0138c78437118c56326097ce0ba..20caea10cc3ceed7acaeff57f4a57ef64adbdf73 100644
--- a/tests/compiler/dart2js/serialization/model_test.dart
+++ b/tests/compiler/dart2js/serialization/model_test.dart
@@ -220,8 +220,17 @@ void checkClassHierarchyNodes(
}
}
if (!found) {
+ if (child.isInstantiated) {
+ print('Missing subclass ${child.cls} of ${node1.cls} '
+ 'in ${node2.directSubclasses}');
+ print(compiler1.world.dump(
+ verbose ? compiler1.coreClasses.objectClass : node1.cls));
+ print(compiler2.world.dump(
+ verbose ? compiler2.coreClasses.objectClass : node2.cls));
+ }
Expect.isFalse(child.isInstantiated,
- 'Missing subclass ${child.cls} of ${node1.cls}');
+ 'Missing subclass ${child.cls} of ${node1.cls} in ${node2
Siggi Cherem (dart-lang) 2016/05/31 21:37:11 nit: split this in 2 strings
Johnni Winther 2016/06/02 08:19:40 Done.
+ .directSubclasses}');
}
}
checkMixinUses(compiler1, compiler2, node1.cls, node2.cls, verbose: verbose);

Powered by Google App Engine
This is Rietveld 408576698