Improve equivalence testing of unnamed mixin applications.

Improve equivalence testing of unnamed mixin applications.

The equivalence of unnamed mixin applications cannot be tested directly since
they are not nominal entities. In the example below two classes by the synthetic
name `S+M` are introduces. This CL adds a reference to the introducing class so
that the unnamed mixin applications can be distinguished as `S+M from C1` and
`S+M from C2`.

class S {}
class M {}
class C1 extends S with M {}
class C2 extends S with M {}

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/5916ee557f0a53e1a0cab14598a5aaece1f8135c

[Johnni Winther, 2016-05-30 11:11:35]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Florian Schneider, 2016-05-30 12:00:58]

fschneider@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2016-05-30 12:00:59]

General drive-by comment: Please add 1-2 sentences in the CL description to
describe the essence of your CL.

[Johnni Winther, 2016-05-30 13:28:56]

The equivalence of unnamed mixin applications cannot be tested directly since
they are not nominal entities. In the example below two classes by the synthetic
name `S+M` are introduces. This CL adds a reference to the introducing class so
that the unnamed mixin applications can be distinguished as `S+M from C1` and
`S+M from C2`.

class S {}
class M {}
class C1 extends S with M {}
class C2 extends S with M {}

[Johnni Winther, 2016-05-30 13:29:09]

Description was changed from

==========
Improve equivalence testing of unnamed mixin applications.

BUG=
==========

to

==========
Improve equivalence testing of unnamed mixin applications.

The equivalence of unnamed mixin applications cannot be tested directly since
they are not nominal entities. In the example below two classes by the synthetic
name `S+M` are introduces. This CL adds a reference to the introducing class so
that the unnamed mixin applications can be distinguished as `S+M from C1` and
`S+M from C2`.

class S {}
class M {}
class C1 extends S with M {}
class C2 extends S with M {}
==========

[Florian Schneider, 2016-05-30 13:39:14]

On 2016/05/30 13:28:56, Johnni Winther wrote:
> The equivalence of unnamed mixin applications cannot be tested directly since
> they are not nominal entities. In the example below two classes by the
synthetic
> name `S+M` are introduces. This CL adds a reference to the introducing class
so
> that the unnamed mixin applications can be distinguished as `S+M from C1` and
> `S+M from C2`.
> 
> class S {}
> class M {}
> class C1 extends S with M {}
> class C2 extends S with M {}

Thanks!

[Siggi Cherem (dart-lang), 2016-05-31 21:37:11]

lgtm

https://codereview.chromium.org/2017903002/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/class_hierarchy.dart (left):

https://codereview.chromium.org/2017903002/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/class_hierarchy.dart:308:
element.compilationUnit,
oh wow, and it used to work?

https://codereview.chromium.org/2017903002/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/serialization/model_test.dart (right):

https://codereview.chromium.org/2017903002/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/serialization/model_test.dart:232: 'Missing subclass
${child.cls} of ${node1.cls} in ${node2
nit: split this in 2 strings

[Johnni Winther, 2016-06-02 08:19:40]

https://codereview.chromium.org/2017903002/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/class_hierarchy.dart (left):

https://codereview.chromium.org/2017903002/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/class_hierarchy.dart:308:
element.compilationUnit,
On 2016/05/31 21:37:11, Siggi Cherem (dart-lang) wrote:
> oh wow, and it used to work?

We only use this for the enclosingElement.

https://codereview.chromium.org/2017903002/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/serialization/model_test.dart (right):

https://codereview.chromium.org/2017903002/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/serialization/model_test.dart:232: 'Missing subclass
${child.cls} of ${node1.cls} in ${node2
On 2016/05/31 21:37:11, Siggi Cherem (dart-lang) wrote:
> nit: split this in 2 strings

Done.

[Johnni Winther, 2016-06-02 08:26:31]

Description was changed from

==========
Improve equivalence testing of unnamed mixin applications.

The equivalence of unnamed mixin applications cannot be tested directly since
they are not nominal entities. In the example below two classes by the synthetic
name `S+M` are introduces. This CL adds a reference to the introducing class so
that the unnamed mixin applications can be distinguished as `S+M from C1` and
`S+M from C2`.

class S {}
class M {}
class C1 extends S with M {}
class C2 extends S with M {}
==========

to

==========
Improve equivalence testing of unnamed mixin applications.

The equivalence of unnamed mixin applications cannot be tested directly since
they are not nominal entities. In the example below two classes by the synthetic
name `S+M` are introduces. This CL adds a reference to the introducing class so
that the unnamed mixin applications can be distinguished as `S+M from C1` and
`S+M from C2`.

class S {}
class M {}
class C1 extends S with M {}
class C2 extends S with M {}

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5916ee557f0a53e1a0cab14598a5aaece1f8135c
==========

[Johnni Winther, 2016-06-02 08:26:33]

Committed patchset #3 (id:40001) manually as
5916ee557f0a53e1a0cab14598a5aaece1f8135c (presubmit successful).