Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 20179004: Don't duplicate OS::CpuFeaturesImpliedByPlatform for every POSIX platform. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 5 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Don't duplicate OS::CpuFeaturesImpliedByPlatform for every POSIX platform. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15873

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -33 lines) Patch
M src/platform-cygwin.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/platform-freebsd.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/platform-linux.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/platform-macos.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/platform-openbsd.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/platform-posix.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/platform-solaris.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
7 years, 5 months ago (2013-07-25 09:05:37 UTC) #1
Sven Panne
lgtm
7 years, 5 months ago (2013-07-25 09:15:43 UTC) #2
Benedikt Meurer
7 years, 5 months ago (2013-07-25 09:16:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15873 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698