Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.cpp

Issue 2017883002: Make revalidation to fail when received a redirect response (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/fetch/Resource.cpp
diff --git a/third_party/WebKit/Source/core/fetch/Resource.cpp b/third_party/WebKit/Source/core/fetch/Resource.cpp
index 029779ee39d9a60a977f94adfd23063322fce7b8..32e830a7d6ad9480963b4f91de7b5e54a718dd2a 100644
--- a/third_party/WebKit/Source/core/fetch/Resource.cpp
+++ b/third_party/WebKit/Source/core/fetch/Resource.cpp
@@ -552,6 +552,9 @@ void Resource::setRevalidatingRequest(const ResourceRequest& request)
void Resource::willFollowRedirect(ResourceRequest& newRequest, const ResourceResponse& redirectResponse)
{
+ if (!m_revalidatingRequest.isNull()) {
+ revalidationFailed();
Nate Chapin 2016/05/27 17:10:43 Would m_redirectChain.clear() suffice?
hiroshige 2016/05/31 06:24:46 No. Just clearing |m_redirectChain| doesn't preven
+ }
kinuko 2016/05/27 14:25:01 nit: no { } for consistency
hiroshige 2016/05/31 13:09:31 Done.
newRequest.setAllowStoredCredentials(m_options.allowCredentials == AllowStoredCredentials);
m_redirectChain.append(RedirectPair(newRequest, redirectResponse));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698