Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2017863002: Fix MSVC C4800 build warnings. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 6 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : self review #

Patch Set 3 : put C4800 back #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -104 lines) Patch
M fpdfsdk/fsdk_baseform.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fwl/core/fwl_formimp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/fwl_formimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffcheckbutton.cpp View 2 chunks +11 lines, -13 lines 0 comments Download
M xfa/fxfa/app/xfa_ffchoicelist.cpp View 1 chunk +15 lines, -18 lines 0 comments Download
M xfa/fxfa/parser/cxfa_widgetdata.h View 3 chunks +12 lines, -13 lines 0 comments Download
M xfa/fxfa/parser/cxfa_widgetdata.cpp View 1 9 chunks +17 lines, -22 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 4 chunks +35 lines, -31 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Lei Zhang
TBR, I tested locally with a Chromium build.
4 years, 7 months ago (2016-05-27 04:53:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017863002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017863002/40001
4 years, 7 months ago (2016-05-27 04:53:34 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://pdfium.googlesource.com/pdfium/+/800222e01e3fcdd57536fc987e773677829dd708
4 years, 7 months ago (2016-05-27 05:00:34 UTC) #7
Wei Li
4 years, 6 months ago (2016-05-27 19:59:39 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698