Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2017853003: [wasm] Remove redundant intermediate data structures in encoder.cc. (Closed)

Created:
4 years, 6 months ago by titzer
Modified:
4 years, 6 months ago
Reviewers:
bradnelson, aseemgarg, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove redundant intermediate data structures in encoder.cc. R=ahaas@chromium.org,bradnelson@chromium.org,aseemgarg@chromium.org BUG= Committed: https://crrev.com/fd2ccd74a87a0a89a77a9a6fd0e2e549261364f7 Cr-Commit-Position: refs/heads/master@{#36546}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -110 lines) Patch
M src/wasm/asm-wasm-builder.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M src/wasm/encoder.h View 4 chunks +20 lines, -41 lines 0 comments Download
M src/wasm/encoder.cc View 7 chunks +14 lines, -55 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 7 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 6 months ago (2016-05-27 09:22:38 UTC) #1
ahaas
lgtm
4 years, 6 months ago (2016-05-27 12:11:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017853003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017853003/1
4 years, 6 months ago (2016-05-27 12:13:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 12:15:30 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 12:16:51 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fd2ccd74a87a0a89a77a9a6fd0e2e549261364f7
Cr-Commit-Position: refs/heads/master@{#36546}

Powered by Google App Engine
This is Rietveld 408576698