BUILD.gn - Issue 2017853002: Add functionality to the install_static library to tokenize strings and compare versions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 2017853002: Add functionality to the install_static library to tokenize strings and compare versions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix windows gn builder redness Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index 308243a275da875ffe16145e2c8d80abc7d0b7fc..841d060c07b3d986286d12a3693d48b42deddd0f 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -575,6 +575,7 @@ group("both_gn_and_gyp") {

if (is_win) {

deps += [

"//base:pe_image_test",

+ "//chrome/install_static:install_static_unittests",

grt (UTC plus 2) 2016/05/27 14:13:20 i think this should be in src/build/gn_migration.g

ananta 2016/05/27 20:05:25 Done.

"//chrome/installer/setup:setup_unittests",

"//chrome_elf:chrome_elf_unittests",

"//chrome_elf:dll_hash_main",

« no previous file with comments | « no previous file | build/all.gyp » ('j') | build/all.gyp » ('J')