Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4824)

Unified Diff: chrome/chrome_installer_static.gypi

Issue 2017853002: Add functionality to the install_static library to tokenize strings and compare versions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/gn_migration.gypi ('k') | chrome/install_static/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_installer_static.gypi
diff --git a/chrome/chrome_installer_static.gypi b/chrome/chrome_installer_static.gypi
index 059588849e37ae3e8c77011c3048bb3661e12383..c4c512d585ad7ab6fbe335a2206281781e0a9e6c 100644
--- a/chrome/chrome_installer_static.gypi
+++ b/chrome/chrome_installer_static.gypi
@@ -46,7 +46,42 @@
},
},
},
+ {
+ 'target_name': 'install_static_unittests',
+ 'type': 'executable',
+ 'sources': [
+ 'install_static/install_util_unittest.cc',
+ ],
+ 'include_dirs': [
+ '..',
+ '<(SHARED_INTERMEDIATE_DIR)',
+ ],
+ 'dependencies': [
+ '../base/base.gyp:base',
+ '../base/base.gyp:run_all_unittests',
+ '../base/base.gyp:test_support_base',
+ 'chrome.gyp:install_static_util',
+ '../testing/gmock.gyp:gmock',
+ '../testing/gtest.gyp:gtest',
+ ],
+ },
],
+ 'conditions': [
+ ['test_isolation_mode != "noop"', {
+ 'targets': [
+ {
+ 'target_name': 'install_static_unittests_run',
+ 'type': 'none',
+ 'dependencies': [
+ 'install_static_unittests',
+ ],
+ 'includes': [ '../build/isolate.gypi' ],
+ 'sources': [
+ 'install_static/install_static_unittests.isolate'
scottmg 2016/05/27 20:57:59 tabs here (rietveld's display of them is currently
ananta 2016/05/27 21:38:54 Done.
+ ],
+ },
+ ],
+ }],
}],
['OS=="win" and target_arch=="ia32"', {
'targets': [
« no previous file with comments | « build/gn_migration.gypi ('k') | chrome/install_static/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698