Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2017803002: Make sure CFDE_XMLSyntaxParser's buffer is null terminated. (Closed)

Created:
4 years, 7 months ago by Oliver Chang
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make sure CFDE_XMLSyntaxParser's buffer is null terminated. BUG=chromium:614962 Committed: https://pdfium.googlesource.com/pdfium/+/816ff7b92ff0f94e4ffaafc975b08d2c4c1a6417

Patch Set 1 #

Patch Set 2 : safeint #

Total comments: 2

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M xfa/fde/xml/fde_xml_imp.cpp View 1 2 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Oliver Chang
Tom, ptal. This prevents FX_wcsnicmp reading past the buffer bounds in CFDE_XMLSyntaxParser::DoSyntaxParse()
4 years, 6 months ago (2016-05-27 16:24:24 UTC) #2
Tom Sepez
lgtm
4 years, 6 months ago (2016-05-27 16:54:24 UTC) #3
Tom Sepez
https://codereview.chromium.org/2017803002/diff/20001/xfa/fde/xml/fde_xml_imp.cpp File xfa/fde/xml/fde_xml_imp.cpp (right): https://codereview.chromium.org/2017803002/diff/20001/xfa/fde/xml/fde_xml_imp.cpp#newcode1480 xfa/fde/xml/fde_xml_imp.cpp:1480: alloc_size_safe += 1; nit: // For NUL.
4 years, 6 months ago (2016-05-27 16:55:11 UTC) #4
Oliver Chang
https://codereview.chromium.org/2017803002/diff/20001/xfa/fde/xml/fde_xml_imp.cpp File xfa/fde/xml/fde_xml_imp.cpp (right): https://codereview.chromium.org/2017803002/diff/20001/xfa/fde/xml/fde_xml_imp.cpp#newcode1480 xfa/fde/xml/fde_xml_imp.cpp:1480: alloc_size_safe += 1; On 2016/05/27 16:55:11, Tom Sepez wrote: ...
4 years, 6 months ago (2016-05-27 17:04:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017803002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017803002/60001
4 years, 6 months ago (2016-05-27 17:04:58 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 17:16:18 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/816ff7b92ff0f94e4ffaafc975b08d2c4c1a...

Powered by Google App Engine
This is Rietveld 408576698