Test CL.

xfa/fwl/core/ifwl_widget.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef XFA_FWL_CORE_IFWL_WIDGET_H_
 #define XFA_FWL_CORE_IFWL_WIDGET_H_
 
 #include <memory>
@@ skipping 30 matching lines @@
   MonthCalendar,
   PictureBox,
   PushButton,
   ScrollBar,
   SpinButton,
   ToolTip
 };
 
 class CFWL_WidgetImp;
 class CFX_Graphics;
+class CXFA_FFWidget;

[Tom Sepez, 2016/05/26 22:34:21]

This is the layering violation.  FWL shouldn't know that XFA exists on top of
it.  FWL is supposed to be an application agnostic layer.

We could try the same trick where IFWL_Widget has some dummy type, but having
done that yesterday, it still feels hokey.

[dsinclair, 2016/05/27 02:57:47]

If that's the case, should we move fwl out of the xfa directory to make the
layering clearer? I was assuming that things inside a top level directory (xfa/,
core/, fpdfsdk/) can see anything in their subtrees.

 class IFWL_App;
 class IFWL_DataProvider;
 class IFWL_Form;
 class IFWL_ThemeProvider;
 class IFWL_WidgetDelegate;
 
 class IFWL_Widget {
  public:
   IFWL_Widget() : m_pImpl(nullptr) {}
   virtual ~IFWL_Widget();
 
   FWL_Error GetWidgetRect(CFX_RectF& rect, FX_BOOL bAutoSize = FALSE);
   FWL_Error GetGlobalRect(CFX_RectF& rect);
   FWL_Error SetWidgetRect(const CFX_RectF& rect);
   FWL_Error GetClientRect(CFX_RectF& rect);
   IFWL_Widget* GetParent();
   FWL_Error SetParent(IFWL_Widget* pParent);
   IFWL_Widget* GetOwner();
   FWL_Error SetOwner(IFWL_Widget* pOwner);
   IFWL_Widget* GetOuter();
   uint32_t GetStyles();
   FWL_Error ModifyStyles(uint32_t dwStylesAdded, uint32_t dwStylesRemoved);
   uint32_t GetStylesEx();
   FWL_Error ModifyStylesEx(uint32_t dwStylesExAdded,
                            uint32_t dwStylesExRemoved);
   uint32_t GetStates();
   void SetStates(uint32_t dwStates, FX_BOOL bSet = TRUE);
   uint32_t GetEventKey() const;
   void SetEventKey(uint32_t key);
-  void* GetLayoutItem() const;
-  void SetLayoutItem(void* pItem);
+  CXFA_FFWidget* GetLayoutItem() const;
+  void SetLayoutItem(CXFA_FFWidget* pItem);
   FWL_Error SetPrivateData(void* module_id,
                            void* pData,
                            PD_CALLBACK_FREEDATA callback);
   void* GetPrivateData(void* module_id);
   FWL_Error Update();
   FWL_Error LockUpdate();
   FWL_Error UnlockUpdate();
   FWL_WidgetHit HitTest(FX_FLOAT fx, FX_FLOAT fy);
   FWL_Error TransformTo(IFWL_Widget* pWidget, FX_FLOAT& fx, FX_FLOAT& fy);
   FWL_Error TransformTo(IFWL_Widget* pWidget, CFX_RectF& rt);
@@ skipping 20 matching lines @@
 
  protected:
   // Takes ownership of |pImpl|.
   void SetImpl(CFWL_WidgetImp* pImpl) { m_pImpl.reset(pImpl); }
 
  private:
   std::unique_ptr<CFWL_WidgetImp> m_pImpl;
 };
 
 #endif  // XFA_FWL_CORE_IFWL_WIDGET_H_