Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2017733002: Turbofan: Rename UnallocatedOperand policies from '*DOUBLE*' to '*FP*'. (Closed)

Created:
4 years, 7 months ago by bbudge
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turbofan: Rename UnallocatedOperand policies from '*DOUBLE*' to '*FP*'. - Renames UnallocatedOperandenum values to reflect the fact that there are multiple FP machine representations. - Renames enum values for RegisterAllocatorVerifier enum. - Template-izes DefineAsFixed and UseFixed methods to handle multiple FP register types. BUG=v8:4124 Committed: https://crrev.com/f50d950052a51e2d4396d2d05392c971fb116538 Cr-Commit-Position: refs/heads/master@{#36558}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -48 lines) Patch
M src/compiler/instruction.h View 1 2 3 6 chunks +16 lines, -15 lines 0 comments Download
M src/compiler/instruction.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction-scheduler.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 2 3 chunks +8 lines, -7 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/register-allocator-verifier.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M src/compiler/register-allocator-verifier.cc View 1 2 3 5 chunks +12 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
bbudge
4 years, 6 months ago (2016-05-27 13:14:36 UTC) #3
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-05-27 17:54:31 UTC) #4
bbudge
+Mircea for changes to RegisterAllocatorVerifier.
4 years, 6 months ago (2016-05-27 18:18:08 UTC) #7
Mircea Trofin
On 2016/05/27 18:18:08, bbudge wrote: > +Mircea for changes to RegisterAllocatorVerifier. lgtm
4 years, 6 months ago (2016-05-27 18:22:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017733002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017733002/60001
4 years, 6 months ago (2016-05-27 18:37:50 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-05-27 18:39:56 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 18:42:14 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f50d950052a51e2d4396d2d05392c971fb116538
Cr-Commit-Position: refs/heads/master@{#36558}

Powered by Google App Engine
This is Rietveld 408576698