Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1323)

Issue 2017723002: DevTools: pretty-print javascript class expression (Closed)

Created:
4 years, 7 months ago by lushnikov
Modified:
4 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: pretty-print javascript class expression BUG=614949 R=dgozman Committed: https://crrev.com/56aa587e59c461867b734a86914df62e73a2cb43 Cr-Commit-Position: refs/heads/master@{#396362}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-classes.html View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-classes-expected.txt View 1 chunk +15 lines, -0 lines 2 comments Download
M third_party/WebKit/Source/devtools/front_end/es_tree/ESTreeWalker.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
lushnikov
зефд
4 years, 7 months ago (2016-05-26 20:46:14 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2017723002/diff/1/third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-classes-expected.txt File third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-classes-expected.txt (right): https://codereview.chromium.org/2017723002/diff/1/third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-classes-expected.txt#newcode95 third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-classes-expected.txt:95: } Kind of strange formatting here...
4 years, 7 months ago (2016-05-26 20:47:51 UTC) #2
lushnikov
Thanks https://codereview.chromium.org/2017723002/diff/1/third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-classes-expected.txt File third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-classes-expected.txt (right): https://codereview.chromium.org/2017723002/diff/1/third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-classes-expected.txt#newcode95 third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-classes-expected.txt:95: } On 2016/05/26 20:47:51, dgozman wrote: > Kind ...
4 years, 7 months ago (2016-05-26 21:03:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017723002/1
4 years, 7 months ago (2016-05-26 21:03:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/229060)
4 years, 7 months ago (2016-05-27 00:14:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017723002/1
4 years, 7 months ago (2016-05-27 00:29:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-27 02:40:47 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-27 02:42:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56aa587e59c461867b734a86914df62e73a2cb43
Cr-Commit-Position: refs/heads/master@{#396362}

Powered by Google App Engine
This is Rietveld 408576698