Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2017703002: Notify InspectorInstrumentation on successfully imported Worklet's script. (Closed)

Created:
4 years, 7 months ago by Gleb Lanbin
Modified:
4 years, 6 months ago
Reviewers:
kinuko, ikilpatrick
CC:
chromium-reviews, blink-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notify InspectorInstrumentation on successfully imported Worklet's script. This ensures the type of the script in the devtools resource panel BUG=567358 Committed: https://crrev.com/7288f608152c4a9b546056e0db0fbb8932a89cfa Cr-Commit-Position: refs/heads/master@{#396506}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M third_party/WebKit/Source/modules/worklet/Worklet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/worklet/Worklet.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Gleb Lanbin
4 years, 7 months ago (2016-05-26 19:42:40 UTC) #2
ikilpatrick
On 2016/05/26 19:42:40, glebl wrote: lgtm I'd also add as a body to the description: ...
4 years, 7 months ago (2016-05-26 22:13:18 UTC) #3
kinuko
lgtm
4 years, 7 months ago (2016-05-27 02:29:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017703002/20001
4 years, 6 months ago (2016-05-27 16:12:31 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-27 17:57:38 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 17:58:36 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7288f608152c4a9b546056e0db0fbb8932a89cfa
Cr-Commit-Position: refs/heads/master@{#396506}

Powered by Google App Engine
This is Rietveld 408576698