Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2017663002: Fix Dartium GOMA builds (-Werror,-Wmismatched-new-delete). (Closed)

Created:
4 years, 7 months ago by rmacnak
Modified:
4 years, 7 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix Dartium GOMA builds (-Werror,-Wmismatched-new-delete). Committed: https://github.com/dart-lang/sdk/commit/48637d1010c05d1f450f7c0df53326a7faf8d0ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/megamorphic_cache_table.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 7 months ago (2016-05-26 16:15:48 UTC) #2
rmacnak
Committed patchset #1 (id:1) manually as 48637d1010c05d1f450f7c0df53326a7faf8d0ad (presubmit successful).
4 years, 7 months ago (2016-05-26 16:16:00 UTC) #4
Ivan Posva
4 years, 7 months ago (2016-05-26 16:17:54 UTC) #5
Message was sent while issue was closed. 
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698