Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 2017633002: Reland of Enable LTO on Linux for the official builds. (Closed)

Created:
4 years, 7 months ago by agrieve
Modified:
4 years, 7 months ago
CC:
chromium-reviews, kcc2, pcc1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Enable LTO on Linux for the official builds. Reason for reland: Uses target_os rather than is_linux This CL turns on Link-Time Optimization for official builds, which makes the resulting binaries to run faster. On the dark side, the change increases the link time by 3x-5x, and is also very memory-hungry. All official bots were upgraded to have 200+ GB RAM to handle LTO builds. Timeouts were also accordingly increased. This CL might cause timeouts / OOMs, if some slaves still have not enough RAM. Please, revert the CL with pointing out to the slaves / bots broken by this change. NOTRY=true TBR=thakis BUG=453195, 615039 Committed: https://crrev.com/c8648b6aef59bf539251dc5242820a83b1a751f9 Cr-Commit-Position: refs/heads/master@{#396186}

Patch Set 1 #

Patch Set 2 : target_os vs is_linux #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M build/common.gypi View 1 1 chunk +7 lines, -0 lines 0 comments Download
M build/toolchain/toolchain.gni View 1 1 chunk +7 lines, -3 lines 1 comment Download

Messages

Total messages: 11 (5 generated)
agrieve
Created Reland of Enable LTO on Linux for the official builds.
4 years, 7 months ago (2016-05-26 15:33:51 UTC) #1
krasin
LGTM
4 years, 7 months ago (2016-05-26 15:39:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017633002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017633002/50001
4 years, 7 months ago (2016-05-26 15:40:21 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:50001)
4 years, 7 months ago (2016-05-26 15:44:12 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c8648b6aef59bf539251dc5242820a83b1a751f9 Cr-Commit-Position: refs/heads/master@{#396186}
4 years, 7 months ago (2016-05-26 15:46:54 UTC) #10
Dirk Pranke
4 years, 7 months ago (2016-05-26 18:26:29 UTC) #11
Message was sent while issue was closed.
lgtm. Good catch; I didn't think about this triggering for the host toolchains.

https://codereview.chromium.org/2017633002/diff/50001/build/toolchain/toolcha...
File build/toolchain/toolchain.gni (right):

https://codereview.chromium.org/2017633002/diff/50001/build/toolchain/toolcha...
build/toolchain/toolchain.gni:17: is_chrome_branded && is_official_build
nit: is_chromeos will never be true of target_os == "linux", so you don't need
that clause.

Powered by Google App Engine
This is Rietveld 408576698