net/cert/merkle_tree_leaf.h - Issue 2017563002: Add Certificate Transparency logs auditing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/merkle_tree_leaf.h

Issue 2017563002: Add Certificate Transparency logs auditing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing all comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/merkle_tree_leaf.h

diff --git a/net/cert/merkle_tree_leaf.h b/net/cert/merkle_tree_leaf.h

index 8f314f56a70641142300f8c6d556ab349178966b..0fd2b3262187aa2fd79dd5e29cc046adfff78317 100644

--- a/net/cert/merkle_tree_leaf.h

+++ b/net/cert/merkle_tree_leaf.h

@@ -23,6 +23,8 @@ namespace ct {

// slightly differently.

Ryan Sleevi 2016/06/30 22:48:19 Does RFC 6962-bis do something differently? It's u

Ryan Sleevi 2016/06/30 22:48:19 Why is it arranged differently?

Eran Messeri 2016/07/01 13:24:01 Yes, 6962-bis does (see details in the other comme

Eran Messeri 2016/07/01 13:24:01 Explained (in another CL).

struct NET_EXPORT MerkleTreeLeaf {

MerkleTreeLeaf();

+ MerkleTreeLeaf(const MerkleTreeLeaf& other);

+ MerkleTreeLeaf(MerkleTreeLeaf&&);

~MerkleTreeLeaf();

// The log id this leaf belongs to.