Add Certificate Transparency logs auditing

components/certificate_transparency/single_tree_tracker_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/certificate_transparency/single_tree_tracker.h"
 
 #include <string>
 #include <utility>
 
 #include "base/strings/string_piece.h"
@@ skipping 45 matching lines @@
 
     ASSERT_TRUE(log_);
     ASSERT_EQ(log_->key_id(), net::ct::GetTestPublicKeyId());
 
     tree_tracker_.reset(new SingleTreeTracker(log_));
     const std::string der_test_cert(net::ct::GetDerEncodedX509Cert());
     chain_ = net::X509Certificate::CreateFromBytes(der_test_cert.data(),
                                                    der_test_cert.length());
     ASSERT_TRUE(chain_.get());
     net::ct::GetX509CertSCT(&cert_sct_);
+    // Because the code will ultimately try to build a MerkleTreeLeaf from
+    // the |chain_| and |cert_sct_|, if the default type, which is an embedded
+    // SCT, is used, leaf construction will fail because GetMerkleTreeLeaf will
+    // expect an intermediate. So change SCT origin to something that relies
+    // solely on |chain_|.

[Ryan Sleevi, 2016/06/30 22:48:19]

LAYERING: This comment strikes me as over-explaining something future /
unrelated.

Are you sure this comment belongs?

[Eran Messeri, 2016/07/01 13:24:01]

I've simply removed the comment. Regardless of the explanation there it's the
right thing to set.

+    cert_sct_->origin =
+        net::ct::SignedCertificateTimestamp::SCT_FROM_OCSP_RESPONSE;
   }
 
  protected:
   scoped_refptr<const net::CTLogVerifier> log_;
   std::unique_ptr<SingleTreeTracker> tree_tracker_;
   scoped_refptr<net::X509Certificate> chain_;
   scoped_refptr<net::ct::SignedCertificateTimestamp> cert_sct_;
 };
 
 // Test that an SCT is classified as pending for a newer STH if the
@@ skipping 73 matching lines @@
   GetOldSignedTreeHead(&sth);
   tree_tracker_->NewSTHObserved(sth);
 
   // Make sure the SCT's state hasn't changed.
   EXPECT_EQ(
       SingleTreeTracker::SCT_PENDING_NEWER_STH,
       tree_tracker_->GetLogEntryInclusionStatus(chain_.get(), cert_sct_.get()));
 }
 
 }  // namespace certificate_transparency