Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2017503002: Remove FX_GAMMA() and friends. They do nothing. (Closed)

Created:
4 years, 6 months ago by Lei Zhang
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove FX_GAMMA() and friends. They do nothing. Committed: https://pdfium.googlesource.com/pdfium/+/008ec70b47db2318a98e8474b7bfac6e10b2bc6c

Patch Set 1 : Remove FX_GAMMA and friends #

Patch Set 2 : merge identical code, no inline #

Patch Set 3 : space things out, anonymous namespace, dead code #

Patch Set 4 : no leading underscore #

Patch Set 5 : nullptr #

Total comments: 2

Patch Set 6 : Blend #

Unified diffs Side-by-side diffs Delta from patch set Stats (+971 lines, -1123 lines) Patch
M core/fxge/agg/fx_agg_driver.cpp View 1 2 3 4 19 chunks +37 lines, -53 lines 0 comments Download
M core/fxge/dib/fx_dib_composite.cpp View 1 2 3 4 5 158 chunks +927 lines, -1046 lines 0 comments Download
M core/fxge/include/fx_ge.h View 1 chunk +1 line, -8 lines 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 1 2 3 4 2 chunks +6 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Lei Zhang
4 years, 6 months ago (2016-05-26 01:27:04 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/2017503002/diff/80001/core/fxge/dib/fx_dib_composite.cpp File core/fxge/dib/fx_dib_composite.cpp (right): https://codereview.chromium.org/2017503002/diff/80001/core/fxge/dib/fx_dib_composite.cpp#newcode37 core/fxge/dib/fx_dib_composite.cpp:37: int BLEND(int blend_mode, int back_color, int src_color) { ...
4 years, 6 months ago (2016-05-26 01:37:50 UTC) #3
Lei Zhang
https://codereview.chromium.org/2017503002/diff/80001/core/fxge/dib/fx_dib_composite.cpp File core/fxge/dib/fx_dib_composite.cpp (right): https://codereview.chromium.org/2017503002/diff/80001/core/fxge/dib/fx_dib_composite.cpp#newcode37 core/fxge/dib/fx_dib_composite.cpp:37: int BLEND(int blend_mode, int back_color, int src_color) { On ...
4 years, 6 months ago (2016-05-26 01:53:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017503002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017503002/100001
4 years, 6 months ago (2016-05-26 01:53:42 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 02:07:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/008ec70b47db2318a98e8474b7bfac6e10b2...

Powered by Google App Engine
This is Rietveld 408576698