Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2017463002: get skia building (Closed)

Created:
4 years, 7 months ago by caryclark
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang, dsinclair, reed1
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

get skia building Resolve changes to cpdf_shadingpattern.h that prevent Skia from building. R=thestig@chromium.org,dsinclair@chromium.org,reed@google.com BUG= Committed: https://pdfium.googlesource.com/pdfium/+/edfd3c3d6a56bee2456e96df4b945c095ea3a290

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M core/fpdfapi/fpdf_page/cpdf_shadingpattern.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 4 chunks +12 lines, -12 lines 1 comment Download

Messages

Total messages: 13 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017463002/1
4 years, 7 months ago (2016-05-25 20:51:14 UTC) #2
caryclark
4 years, 7 months ago (2016-05-25 20:51:20 UTC) #3
Lei Zhang
Doh, did I break Skia again? :(
4 years, 7 months ago (2016-05-25 20:52:56 UTC) #4
dsinclair
lgtm. How close do you think you are to us being able to setup a ...
4 years, 7 months ago (2016-05-25 20:54:22 UTC) #5
Lei Zhang
lgtm https://codereview.chromium.org/2017463002/diff/1/core/fxge/skia/fx_skia_device.cpp File core/fxge/skia/fx_skia_device.cpp (right): https://codereview.chromium.org/2017463002/diff/1/core/fxge/skia/fx_skia_device.cpp#newcode763 core/fxge/skia/fx_skia_device.cpp:763: int nFuncs = pFuncs.size(); size_t, |j| on line ...
4 years, 7 months ago (2016-05-25 20:54:23 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-25 21:03:02 UTC) #8
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-25 21:03:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017463002/1
4 years, 7 months ago (2016-05-25 21:08:10 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 21:08:35 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/edfd3c3d6a56bee2456e96df4b945c095ea3...

Powered by Google App Engine
This is Rietveld 408576698