cc: Send notification of tasks completion directly without scheduling.

cc/tiles/tile_manager.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_TILES_TILE_MANAGER_H_
 #define CC_TILES_TILE_MANAGER_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
 #include <set>
 #include <unordered_map>
 #include <utility>
 #include <vector>
 
 #include "base/macros.h"
 #include "base/values.h"
-#include "cc/base/unique_notifier.h"
 #include "cc/playback/raster_source.h"
 #include "cc/raster/raster_buffer_provider.h"
 #include "cc/resources/memory_history.h"
 #include "cc/resources/resource_pool.h"
 #include "cc/tiles/eviction_tile_priority_queue.h"
 #include "cc/tiles/image_decode_controller.h"
 #include "cc/tiles/raster_tile_priority_queue.h"
 #include "cc/tiles/tile.h"
 #include "cc/tiles/tile_draw_info.h"
 #include "cc/tiles/tile_task_manager.h"
@@ skipping 231 matching lines @@
       MemoryUsage* usage);
   std::unique_ptr<EvictionTilePriorityQueue>
   FreeTileResourcesWithLowerPriorityUntilUsageIsWithinLimit(
       std::unique_ptr<EvictionTilePriorityQueue> eviction_priority_queue,
       const MemoryUsage& limit,
       const TilePriority& oother_priority,
       MemoryUsage* usage);
   bool TilePriorityViolatesMemoryPolicy(const TilePriority& priority);
   bool AreRequiredTilesReadyToDraw(RasterTilePriorityQueue::Type type) const;
   void CheckIfMoreTilesNeedToBePrepared();
-  void CheckAndIssueSignals();
+  void CheckAndNotifyReadyToActivate();
+  void CheckAndNotifyReadyToDraw();
+  void CheckAndNotifyAllTileTasksCompleted();
   bool MarkTilesOutOfMemory(
       std::unique_ptr<RasterTilePriorityQueue> queue) const;
 
   ResourceFormat DetermineResourceFormat(const Tile* tile) const;
   bool DetermineResourceRequiresSwizzle(const Tile* tile) const;
 
-  void DidFinishRunningTileTasksRequiredForActivation();
-  void DidFinishRunningTileTasksRequiredForDraw();
-  void DidFinishRunningAllTileTasks();
+  void DidFinishRunningTileTasksRequiredForActivation(
+      uint64_t source_prepare_tiles_id);
+  void DidFinishRunningTileTasksRequiredForDraw(
+      uint64_t source_prepare_tiles_id);
+  void DidFinishRunningAllTileTasks(uint64_t source_prepare_tiles_id);
 
   scoped_refptr<TileTask> CreateTaskSetFinishedTask(
-      void (TileManager::*callback)());
+      void (TileManager::*callback)(uint64_t source_prepare_tiles_id));
 
   std::unique_ptr<base::trace_event::ConvertableToTraceFormat>
   ScheduledTasksStateAsValue() const;
 
   TileManagerClient* client_;
   scoped_refptr<base::SequencedTaskRunner> task_runner_;
   ResourcePool* resource_pool_;
   TileTaskManager* tile_task_manager_;
   GlobalStateThatImpactsTilePriority global_state_;
   size_t scheduled_raster_task_limit_;
@@ skipping 15 matching lines @@
 
   std::vector<Tile*> released_tiles_;
 
   std::vector<scoped_refptr<TileTask>> orphan_tasks_;
 
   TaskGraph graph_;
   scoped_refptr<TileTask> required_for_activation_done_task_;
   scoped_refptr<TileTask> required_for_draw_done_task_;
   scoped_refptr<TileTask> all_done_task_;
 
-  UniqueNotifier more_tiles_need_prepare_check_notifier_;
-
   struct Signals {
     Signals();
 
     void reset();
 
     bool ready_to_activate;
     bool did_notify_ready_to_activate;
     bool ready_to_draw;
     bool did_notify_ready_to_draw;
     bool all_tile_tasks_completed;
     bool did_notify_all_tile_tasks_completed;
   } signals_;

[prashant.n, 2016/05/30 14:38:27]

1. From above structure
ready_to_activate, ready_to_draw and all_tile_tasks_completed

and has_scheduled_tile_tasks_

2. 


are purely needed for tracing.

Do let me know if want to keep this or remove.

 
-  UniqueNotifier signals_check_notifier_;
-
   bool has_scheduled_tile_tasks_;
 
   uint64_t prepare_tiles_count_;
   uint64_t next_tile_id_;
 
   std::unordered_map<Tile::Id, std::vector<DrawImage>> scheduled_draw_images_;
 
   base::WeakPtrFactory<TileManager> task_set_finished_weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(TileManager);
 };
 
 }  // namespace cc
 
 #endif  // CC_TILES_TILE_MANAGER_H_