Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2802)

Unified Diff: ash/wm/immersive_fullscreen_controller_unittest.cc

Issue 2017413002: ash: Fix variable names and setters in ShelfLayoutManager and tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shellshelf
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/immersive_fullscreen_controller_unittest.cc
diff --git a/ash/wm/immersive_fullscreen_controller_unittest.cc b/ash/wm/immersive_fullscreen_controller_unittest.cc
index 18b07f7b6e1b5a19834e23c51c497e774a799dda..4e05ddf78517ba00f4568d472c562b5f410df68d 100644
--- a/ash/wm/immersive_fullscreen_controller_unittest.cc
+++ b/ash/wm/immersive_fullscreen_controller_unittest.cc
@@ -7,7 +7,7 @@
#include "ash/display/display_manager.h"
#include "ash/display/mouse_cursor_event_filter.h"
#include "ash/root_window_controller.h"
-#include "ash/shelf/shelf_layout_manager.h"
+#include "ash/shelf/shelf.h"
#include "ash/shelf/shelf_types.h"
#include "ash/shell.h"
#include "ash/test/ash_test_base.h"
@@ -1035,39 +1035,38 @@ TEST_F(ImmersiveFullscreenControllerTest, Bubbles) {
// immersive fullscreen and that the shelf's state before entering immersive
// fullscreen is restored upon exiting immersive fullscreen.
TEST_F(ImmersiveFullscreenControllerTest, Shelf) {
- ash::ShelfLayoutManager* shelf =
- ash::Shell::GetPrimaryRootWindowController()->GetShelfLayoutManager();
+ Shelf* shelf = Shelf::ForPrimaryDisplay();
// Shelf is visible by default.
window()->SetProperty(aura::client::kShowStateKey, ui::SHOW_STATE_NORMAL);
ASSERT_FALSE(controller()->IsEnabled());
- ASSERT_EQ(ash::SHELF_VISIBLE, shelf->visibility_state());
+ ASSERT_EQ(SHELF_VISIBLE, shelf->GetVisibilityState());
// Entering immersive fullscreen sets the shelf to auto hide.
window()->SetProperty(aura::client::kShowStateKey, ui::SHOW_STATE_FULLSCREEN);
SetEnabled(true);
- EXPECT_EQ(ash::SHELF_AUTO_HIDE, shelf->visibility_state());
+ EXPECT_EQ(SHELF_AUTO_HIDE, shelf->GetVisibilityState());
// Disabling immersive fullscreen puts it back.
SetEnabled(false);
window()->SetProperty(aura::client::kShowStateKey, ui::SHOW_STATE_NORMAL);
ASSERT_FALSE(controller()->IsEnabled());
- EXPECT_EQ(ash::SHELF_VISIBLE, shelf->visibility_state());
+ EXPECT_EQ(SHELF_VISIBLE, shelf->GetVisibilityState());
// The user could toggle the shelf auto-hide behavior.
- shelf->SetAutoHideBehavior(ash::SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS);
- EXPECT_EQ(ash::SHELF_AUTO_HIDE, shelf->visibility_state());
+ shelf->SetAutoHideBehavior(SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS);
+ EXPECT_EQ(SHELF_AUTO_HIDE, shelf->GetVisibilityState());
// Entering immersive fullscreen keeps auto-hide.
window()->SetProperty(aura::client::kShowStateKey, ui::SHOW_STATE_FULLSCREEN);
SetEnabled(true);
- EXPECT_EQ(ash::SHELF_AUTO_HIDE, shelf->visibility_state());
+ EXPECT_EQ(SHELF_AUTO_HIDE, shelf->GetVisibilityState());
// Disabling immersive fullscreen maintains the user's auto-hide selection.
SetEnabled(false);
window()->SetProperty(aura::client::kShowStateKey,
ui::SHOW_STATE_NORMAL);
- EXPECT_EQ(ash::SHELF_AUTO_HIDE, shelf->visibility_state());
+ EXPECT_EQ(SHELF_AUTO_HIDE, shelf->GetVisibilityState());
}
} // namespase ash

Powered by Google App Engine
This is Rietveld 408576698