ash/wm/panels/panel_window_resizer_unittest.cc - Issue 2017413002: ash: Fix variable names and setters in ShelfLayoutManager and tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/panels/panel_window_resizer_unittest.cc

Issue 2017413002: ash: Fix variable names and setters in ShelfLayoutManager and tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shellshelf

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc ('K') | « ash/wm/panels/panel_layout_manager_unittest.cc ('k') | ash/wm/workspace/workspace_layout_manager_unittest.cc » ('j') | ash/wm/workspace/workspace_window_resizer_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/wm/panels/panel_window_resizer_unittest.cc

diff --git a/ash/wm/panels/panel_window_resizer_unittest.cc b/ash/wm/panels/panel_window_resizer_unittest.cc

index 1329dd73eb4cb7d9fecfe8a60adc8558aa9b3b22..f1d8f40270622b1bc1fb8983039829f34a74c521 100644

--- a/ash/wm/panels/panel_window_resizer_unittest.cc

+++ b/ash/wm/panels/panel_window_resizer_unittest.cc

@@ -268,11 +268,9 @@ TEST_F(PanelWindowResizerTest, DetachThenHideShelf) {

// Hide the shelf. This minimizes all attached windows but should ignore

// the dragged window.

- ShelfLayoutManager* layout_manager =

- RootWindowController::ForWindow(window.get())

- ->shelf_widget()

- ->shelf_layout_manager();

- layout_manager->SetAutoHideBehavior(SHELF_AUTO_HIDE_ALWAYS_HIDDEN);

+ Shelf* shelf = RootWindowController::ForWindow(window.get())->GetShelf();

+ shelf->SetAutoHideBehavior(SHELF_AUTO_HIDE_ALWAYS_HIDDEN);

+ ShelfLayoutManager* layout_manager = shelf->shelf_layout_manager();

msw 2016/06/01 00:53:24 nit: inline below?

James Cook 2016/06/01 15:53:07 Done.

layout_manager->UpdateVisibilityState();

RunAllPendingInMessageLoop();

EXPECT_FALSE(state->IsMinimized());