ash/shelf/shelf_view_unittest.cc - Issue 2017413002: ash: Fix variable names and setters in ShelfLayoutManager and tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shelf/shelf_view_unittest.cc

Issue 2017413002: ash: Fix variable names and setters in ShelfLayoutManager and tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shellshelf

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/shelf/shelf_layout_manager_unittest.cc ('K') | « ash/shelf/shelf_tooltip_manager_unittest.cc ('k') | ash/shelf/shelf_widget_unittest.cc » ('j') | ash/system/tray/system_tray_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/shelf/shelf_view_unittest.cc

diff --git a/ash/shelf/shelf_view_unittest.cc b/ash/shelf/shelf_view_unittest.cc

index e83387b7f3a7ed603628bc9bf2862affd962aa35..3b0c8da74dd68215e326a9fe1ded7fbf9917ce9b 100644

--- a/ash/shelf/shelf_view_unittest.cc

+++ b/ash/shelf/shelf_view_unittest.cc

@@ -1358,12 +1358,10 @@ TEST_F(ShelfViewTest, ShelfItemStatusPlatformApp) {

// Confirm that shelf item bounds are correctly updated on shelf changes.

TEST_F(ShelfViewTest, ShelfItemBoundsCheck) {

VerifyShelfItemBoundsAreValid();

- shelf_view_->shelf()->shelf_layout_manager()->SetAutoHideBehavior(

- SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS);

+ shelf_view_->shelf()->SetAutoHideBehavior(SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS);

test_api_->RunMessageLoopUntilAnimationsDone();

VerifyShelfItemBoundsAreValid();

- shelf_view_->shelf()->shelf_layout_manager()->SetAutoHideBehavior(

- SHELF_AUTO_HIDE_BEHAVIOR_NEVER);

+ shelf_view_->shelf()->SetAutoHideBehavior(SHELF_AUTO_HIDE_BEHAVIOR_NEVER);

test_api_->RunMessageLoopUntilAnimationsDone();

VerifyShelfItemBoundsAreValid();

}