ash/shelf/shelf_tooltip_manager_unittest.cc - Issue 2017413002: ash: Fix variable names and setters in ShelfLayoutManager and tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shelf/shelf_tooltip_manager_unittest.cc

Issue 2017413002: ash: Fix variable names and setters in ShelfLayoutManager and tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shellshelf

Patch Set: review comments 3 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/shelf/shelf_tooltip_manager_unittest.cc

diff --git a/ash/shelf/shelf_tooltip_manager_unittest.cc b/ash/shelf/shelf_tooltip_manager_unittest.cc

index 72dcaced973866571a5e23b78ca9796f8c7817cc..b3df6ed1081273f80ce900cfe0d077eca10cadb7 100644

--- a/ash/shelf/shelf_tooltip_manager_unittest.cc

+++ b/ash/shelf/shelf_tooltip_manager_unittest.cc

@@ -122,10 +122,9 @@ TEST_F(ShelfTooltipManagerTest, HideWhenShelfIsAutoHide) {

ShowImmediately();

ASSERT_TRUE(TooltipIsVisible());

- ShelfLayoutManager* shelf_layout_manager = shelf_->shelf_layout_manager();

- shelf_layout_manager->SetAutoHideBehavior(SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS);

- shelf_layout_manager->UpdateAutoHideState();

- ASSERT_EQ(SHELF_AUTO_HIDE_HIDDEN, shelf_layout_manager->auto_hide_state());

+ shelf_->SetAutoHideBehavior(SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS);

+ shelf_->shelf_layout_manager()->UpdateAutoHideState();

+ ASSERT_EQ(SHELF_AUTO_HIDE_HIDDEN, shelf_->GetAutoHideState());

// Tooltip visibility change for auto hide may take time.

EXPECT_TRUE(TooltipIsVisible());

« no previous file with comments | « ash/shelf/shelf_layout_manager_unittest.cc ('k') | ash/shelf/shelf_view_unittest.cc » ('j') | no next file with comments »