Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2017403003: Disable file operations on NACL builds. (Closed)

Created:
4 years, 6 months ago by bcwhite
Modified:
4 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable file operations on NACL builds. This hasn't affected existing builds because nothing was trying to access them and thus the absence of downstream dependencies is not causing a build failure. The failure occurs if new code makes any reference to it. BUG=546019 Committed: https://crrev.com/9e68eef8d18a7a27c1b896e92de23bef3b933031 Cr-Commit-Position: refs/heads/master@{#396733}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M base/metrics/persistent_memory_allocator.h View 2 chunks +2 lines, -0 lines 0 comments Download
M base/metrics/persistent_memory_allocator.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M base/metrics/persistent_memory_allocator_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
bcwhite
4 years, 6 months ago (2016-05-30 13:14:37 UTC) #2
Alexei Svitkine (slow)
lgtm
4 years, 6 months ago (2016-05-30 14:31:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017403003/1
4 years, 6 months ago (2016-05-30 14:37:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 15:40:41 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 15:42:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e68eef8d18a7a27c1b896e92de23bef3b933031
Cr-Commit-Position: refs/heads/master@{#396733}

Powered by Google App Engine
This is Rietveld 408576698