Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2017373002: Update README a bit and add Contributing info (Closed)

Created:
4 years, 6 months ago by anatoly techtonik
Modified:
4 years, 5 months ago
Reviewers:
dpranke, iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address review comments #

Patch Set 3 : Rename to README.md for Gitiles #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -46 lines) Patch
M README View 1 2 1 chunk +0 lines, -34 lines 0 comments Download
A + README.md View 1 2 2 chunks +33 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
anatoly techtonik
This needs review as I am confused about how to keep depot_tools updated - with ...
4 years, 6 months ago (2016-05-29 08:30:37 UTC) #2
iannucci
On 2016/05/29 08:30:37, anatoly techtonik wrote: > This needs review as I am confused about ...
4 years, 5 months ago (2016-07-19 01:33:00 UTC) #3
iannucci
https://chromiumcodereview.appspot.com/2017373002/diff/1/README File README (right): https://chromiumcodereview.appspot.com/2017373002/diff/1/README#newcode21 README:21: It updates itself automatically. To disable automatic updating, set ...
4 years, 5 months ago (2016-07-19 01:33:07 UTC) #4
anatoly techtonik
On 2016/07/19 01:33:00, iannucci wrote: > On 2016/05/29 08:30:37, anatoly techtonik wrote: > > This ...
4 years, 5 months ago (2016-07-20 12:16:04 UTC) #5
iannucci
On 2016/07/20 12:16:04, anatoly techtonik wrote: > On 2016/07/19 01:33:00, iannucci wrote: > > On ...
4 years, 5 months ago (2016-07-20 18:29:22 UTC) #6
iannucci
On 2016/07/20 18:29:22, iannucci wrote: > On 2016/07/20 12:16:04, anatoly techtonik wrote: > > On ...
4 years, 5 months ago (2016-07-20 18:30:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2017373002/40001
4 years, 5 months ago (2016-07-20 21:01:13 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/d224cb7e497a4bf950404320328b906d57ee2a71
4 years, 5 months ago (2016-07-20 21:04:10 UTC) #11
anatoly techtonik
4 years, 5 months ago (2016-07-21 06:32:38 UTC) #12
Message was sent while issue was closed.
Live! =) Thanks for review.

Powered by Google App Engine
This is Rietveld 408576698