Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 2017323002: Disable HTTP/2 Alternative Service for different host. (Closed)

Created:
4 years, 6 months ago by Bence
Modified:
4 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable HTTP/2 Alternative Service for different host. Disable HTTP/2 Alternative Service if origin and alternative have different hostnames. This is a temporary workaround until https://crbug.com/615413 is fixed. BUG=615637 Committed: https://crrev.com/8bef8da2318c3684b94c866bf194e8c427195b6a Cr-Commit-Position: refs/heads/master@{#396665}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Do not change port except for a small number of tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -23 lines) Patch
M net/http/http_network_transaction_unittest.cc View 1 11 chunks +67 lines, -23 lines 0 comments Download
M net/http/http_stream_factory_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 6 months ago (2016-05-28 23:21:22 UTC) #2
Ryan Hamilton
lgtm https://codereview.chromium.org/2017323002/diff/1/net/http/http_network_transaction_unittest.cc File net/http/http_network_transaction_unittest.cc (right): https://codereview.chromium.org/2017323002/diff/1/net/http/http_network_transaction_unittest.cc#newcode330 net/http/http_network_transaction_unittest.cc:330: "=\"www.example.org:444\"\r\n"; Are the changes from com:443 -> org:444 ...
4 years, 6 months ago (2016-05-28 23:28:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017323002/20001
4 years, 6 months ago (2016-05-30 01:09:19 UTC) #6
Bence
Thank you. https://codereview.chromium.org/2017323002/diff/1/net/http/http_network_transaction_unittest.cc File net/http/http_network_transaction_unittest.cc (right): https://codereview.chromium.org/2017323002/diff/1/net/http/http_network_transaction_unittest.cc#newcode330 net/http/http_network_transaction_unittest.cc:330: "=\"www.example.org:444\"\r\n"; On 2016/05/28 23:28:45, Ryan Hamilton wrote: ...
4 years, 6 months ago (2016-05-30 01:09:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-30 01:28:37 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 01:30:22 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8bef8da2318c3684b94c866bf194e8c427195b6a
Cr-Commit-Position: refs/heads/master@{#396665}

Powered by Google App Engine
This is Rietveld 408576698