third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp - Issue 2017303002: Revert of Remove StringBuilder::appendLiteral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp

Issue 2017303002: Revert of Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp

diff --git a/third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp b/third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp

index 267e0d9e67eb2c4cbb72fe02f5cacfe74020f51a..2818bf9bdb29e22d2b3541f083cd0aace44e1c64 100644

--- a/third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp

+++ b/third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp

@@ -108,7 +108,7 @@

StringBuilder headerBuffer;

for (const String& header : headers) {

if (!headerBuffer.isEmpty())

- headerBuffer.append(", ");

+ headerBuffer.appendLiteral(", ");

headerBuffer.append(header);

}

preflightRequest.setHTTPHeaderField(HTTPNames::Access_Control_Request_Headers, AtomicString(headerBuffer.toString()));