third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp - Issue 2017303002: Revert of Remove StringBuilder::appendLiteral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp

Issue 2017303002: Revert of Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp

diff --git a/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp b/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp

index 18c91d8da76e48fb55b57e41957febcfdedc9efe..2fe149e29c06485d9f80e97b790754bf261cc5d3 100644

--- a/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp

+++ b/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp

@@ -384,7 +384,7 @@

m_isRawDataConverted = true;

StringBuilder builder;

- builder.append("data:");

+ builder.appendLiteral("data:");

if (!m_bytesLoaded) {

m_stringResult = builder.toString();

@@ -392,7 +392,7 @@

}

builder.append(m_dataType);

- builder.append(";base64,");

+ builder.appendLiteral(";base64,");

Vector<char> out;

base64Encode(static_cast<const char*>(m_rawData->data()), m_rawData->byteLength(), out);