third_party/WebKit/Source/core/editing/VisibleSelection.cpp - Issue 2017303002: Revert of Remove StringBuilder::appendLiteral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Issue 2017303002: Revert of Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp

index c7aadb753210287c7844257a01a911b3a62aaa26..abfaeda96f861d85892fc11b1bf5c63034a33fb4 100644

--- a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp

+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp

@@ -917,14 +917,14 @@

String s;

if (isNone()) {

- result.append("<none>");

+ result.appendLiteral("<none>");

} else {

const int FormatBufferSize = 1024;

char s[FormatBufferSize];

- result.append("from ");

+ result.appendLiteral("from ");

start().formatForDebugger(s, FormatBufferSize);

result.append(s);

- result.append(" to ");

+ result.appendLiteral(" to ");

end().formatForDebugger(s, FormatBufferSize);

result.append(s);

}