Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1768)

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2017283002: MD Settings: implement printing page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_resources.grd ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
index b59a0afbd233825995f8c4d4c2171c502823b42d..21e380803abee08f1a17bda35b2a5595d2a03d9d 100644
--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
@@ -350,14 +350,6 @@ void AddClearBrowsingDataStrings(content::WebUIDataSource* html_source) {
arraysize(localized_strings));
}
-void AddCloudPrintStrings(content::WebUIDataSource* html_source) {
- LocalizedString localized_strings[] = {
- {"googleCloudPrint", IDS_SETTINGS_GOOGLE_CLOUD_PRINT},
- };
- AddLocalizedStringsBulk(html_source, localized_strings,
- arraysize(localized_strings));
-}
-
#if !defined(OS_CHROMEOS)
void AddDefaultBrowserStrings(content::WebUIDataSource* html_source) {
LocalizedString localized_strings[] = {
@@ -767,6 +759,23 @@ void AddPeopleStrings(content::WebUIDataSource* html_source) {
base::ASCIIToUTF16(chrome::kGoogleAccountActivityControlsURL));
}
+void AddPrintingStrings(content::WebUIDataSource* html_source) {
+ LocalizedString localized_strings[] = {
+ {"printingPageTitle", IDS_SETTINGS_PRINTING},
+ {"printingCloudPrintLearnMoreLabel",
+ IDS_SETTINGS_PRINTING_CLOUD_PRINT_LEARN_MORE_LABEL},
+ {"printingNotificationsLabel", IDS_SETTINGS_PRINTING_NOTIFICATIONS_LABEL},
+ {"printingManageCloudPrintDevices",
+ IDS_SETTINGS_PRINTING_MANAGE_CLOUD_PRINT_DEVICES},
+ };
+ AddLocalizedStringsBulk(html_source, localized_strings,
+ arraysize(localized_strings));
+
+ html_source->AddString("devicesUrl", chrome::kChromeUIDevicesURL);
+ html_source->AddString("printingCloudPrintLearnMoreUrl",
+ chrome::kCloudPrintLearnMoreURL);
Dan Beam 2016/05/28 01:13:11 both of these URLs already existed in C++, so to a
+}
+
void AddPrivacyStrings(content::WebUIDataSource* html_source) {
LocalizedString localized_strings[] = {
{"privacyPageTitle", IDS_SETTINGS_PRIVACY},
@@ -1011,7 +1020,6 @@ void AddLocalizedStrings(content::WebUIDataSource* html_source,
AddCertificateManagerStrings(html_source);
#endif
AddClearBrowsingDataStrings(html_source);
- AddCloudPrintStrings(html_source);
#if !defined(OS_CHROMEOS)
AddDefaultBrowserStrings(html_source);
#endif
@@ -1032,6 +1040,7 @@ void AddLocalizedStrings(content::WebUIDataSource* html_source,
AddOnStartupStrings(html_source);
AddPasswordsAndFormsStrings(html_source);
AddPeopleStrings(html_source);
+ AddPrintingStrings(html_source);
AddPrivacyStrings(html_source);
AddResetStrings(html_source);
AddSearchEnginesStrings(html_source);
« no previous file with comments | « chrome/browser/resources/settings/settings_resources.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698