MD Settings: implement printing page

MD Settings: implement printing page

Adds the section as per the mocks on the bug and a side-nav item/route

BUG=602464
R=dschuyler@chromium.org
TBR=michaelpg@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/70c95b1e895c633a514b21b6d96fef3abe866ec9
Cr-Commit-Position: refs/heads/master@{#396635}

[Dan Beam, 2016-05-28 01:10:45]

Description was changed from

==========
MD Settings: implement printing page

Adds the section as per the mocks on the bug and a side-nav item/route

BUG=602464
R=dschuyler@chromium.org
==========

to

==========
MD Settings: implement printing page

Adds the section as per the mocks on the bug and a side-nav item/route

BUG=602464
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-05-28 01:13:11]

i tried to think of things to test, but this is a pretty basic section... so I
just manually tested everything I could think of (i.e. clicking the nav item,
the checkbox with the old settings page open, the learn more link, and the
manage button)

https://codereview.chromium.org/2017283002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/2017283002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:776:
chrome::kCloudPrintLearnMoreURL);
both of these URLs already existed in C++, so to avoid copying them (and their
logic in the case of cloud print), I'm just sending them down

[dschuyler, 2016-05-28 01:40:27]

LGTM as an initial pass.

Maybe a followup CL could add a
compiled_resources2.gyp?

Maybe a unit test could grab the learn
more URL from the page and from loadTimeData
and compare them (to be sure they replaced
correctly)?

[Dan Beam, 2016-05-28 01:48:48]

dbeam@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Dan Beam, 2016-05-28 01:48:48]

+michaelpg for prefs_util.cc

[Dan Beam, 2016-05-28 01:50:46]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-28 01:51:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2017283002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2017283002/1

[commit-bot: I haz the power, 2016-05-28 01:52:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-28 01:52:40]

Dry run: Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[Dan Beam, 2016-05-28 02:59:28]

Description was changed from

==========
MD Settings: implement printing page

Adds the section as per the mocks on the bug and a side-nav item/route

BUG=602464
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: implement printing page

Adds the section as per the mocks on the bug and a side-nav item/route

BUG=602464
R=dschuyler@chromium.org
TBR=michaelpg@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-05-28 02:59:49]

eh, TBR=michaelpg@ for 2 line change in prefs_util.cc (just adding another pref
to the whitelist)

[Dan Beam, 2016-05-28 02:59:54]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-05-28 02:59:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2017283002/#ps20001
(title: "asdf")

[commit-bot: I haz the power, 2016-05-28 03:00:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2017283002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2017283002/20001

[commit-bot: I haz the power, 2016-05-28 04:44:24]

Description was changed from

==========
MD Settings: implement printing page

Adds the section as per the mocks on the bug and a side-nav item/route

BUG=602464
R=dschuyler@chromium.org
TBR=michaelpg@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: implement printing page

Adds the section as per the mocks on the bug and a side-nav item/route

BUG=602464
R=dschuyler@chromium.org
TBR=michaelpg@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-05-28 04:44:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-28 04:46:27]

Description was changed from

==========
MD Settings: implement printing page

Adds the section as per the mocks on the bug and a side-nav item/route

BUG=602464
R=dschuyler@chromium.org
TBR=michaelpg@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: implement printing page

Adds the section as per the mocks on the bug and a side-nav item/route

BUG=602464
R=dschuyler@chromium.org
TBR=michaelpg@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/70c95b1e895c633a514b21b6d96fef3abe866ec9
Cr-Commit-Position: refs/heads/master@{#396635}
==========

[commit-bot: I haz the power, 2016-05-28 04:46:28]

Patchset 2 (id:??) landed as
https://crrev.com/70c95b1e895c633a514b21b6d96fef3abe866ec9
Cr-Commit-Position: refs/heads/master@{#396635}