Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2017273002: Support USB device hotplug on Android. (Closed)

Created:
4 years, 6 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 6 months ago
Reviewers:
juncai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support USB device hotplug on Android. This patch registers a broadcast receiver for the UsbManager's device attach and detach events. BUG=601627 Committed: https://crrev.com/16001d9033faf76fe53926cc6d4d25f6c9b12aca Cr-Commit-Position: refs/heads/master@{#396995}

Patch Set 1 #

Patch Set 2 : Add dependency on //device/usb:java. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -20 lines) Patch
M device/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M device/usb/android/java/src/org/chromium/device/usb/ChromeUsbDevice.java View 1 chunk +5 lines, -0 lines 0 comments Download
M device/usb/android/java/src/org/chromium/device/usb/ChromeUsbService.java View 3 chunks +43 lines, -3 lines 0 comments Download
M device/usb/usb_device_android.h View 2 chunks +4 lines, -0 lines 0 comments Download
M device/usb/usb_device_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M device/usb/usb_service_android.h View 2 chunks +17 lines, -0 lines 0 comments Download
M device/usb/usb_service_android.cc View 2 chunks +68 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 6 months ago (2016-05-28 00:01:30 UTC) #2
juncai
LGTM.
4 years, 6 months ago (2016-05-31 17:37:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017273002/1
4 years, 6 months ago (2016-05-31 17:57:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/79150)
4 years, 6 months ago (2016-05-31 20:08:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017273002/20001
4 years, 6 months ago (2016-05-31 22:44:49 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 00:44:42 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 00:45:48 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/16001d9033faf76fe53926cc6d4d25f6c9b12aca
Cr-Commit-Position: refs/heads/master@{#396995}

Powered by Google App Engine
This is Rietveld 408576698