cc: Move copy requests from layers to the effect tree

cc: Move copy requests from layers to the effect tree

This makes the effect tree own copy requests. Clients still add copy
requests to individual Layers, but these are moved to the effect tree
at property-tree-building time, and then pushed with the effect tree
during commit and activation. This is a step towards removing the
dependency of RenderSurfaceImpls on their owning LayerImpl.

BUG=612208
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc
Cr-Commit-Position: refs/heads/master@{#396848}

[ajuma, 2016-05-27 23:53:07]

Description was changed from

==========
WIP: cc: Move copy requests to the effect tree

BUG=
==========

to

==========
WIP: cc: Move copy requests to the effect tree

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[ajuma, 2016-05-30 23:30:30]

Description was changed from

==========
WIP: cc: Move copy requests to the effect tree

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Move copy requests from layers to the effect tree

This makes the effect tree own copy requests. Clients still add copy
requests to individual Layers, but these are moved to the effect tree
at property-tree-building time, and then pushed with the effect tree
during commit and activation. This is a step towards removing the
dependency of RenderSurfaceImpls on their owning LayerImpl.

BUG=612208
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[ajuma, 2016-05-30 23:32:06]

Description was changed from

==========
cc: Move copy requests from layers to the effect tree

This makes the effect tree own copy requests. Clients still add copy
requests to individual Layers, but these are moved to the effect tree
at property-tree-building time, and then pushed with the effect tree
during commit and activation. This is a step towards removing the
dependency of RenderSurfaceImpls on their owning LayerImpl.

BUG=612208
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Move copy requests from layers to the effect tree

This makes the effect tree own copy requests. Clients still add copy
requests to individual Layers, but these are moved to the effect tree
at property-tree-building time, and then pushed with the effect tree
during commit and activation. This is a step towards removing the
dependency of RenderSurfaceImpls on their owning LayerImpl.

BUG=612208
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[ajuma, 2016-05-30 23:32:06]

ajuma@chromium.org changed reviewers:
+ jaydasika@chromium.org, vollick@chromium.org

[Ian Vollick, 2016-05-31 01:47:13]

lgtm.

https://codereview.chromium.org/2017263002/diff/80001/cc/trees/property_tree.cc
File cc/trees/property_tree.cc (right):

https://codereview.chromium.org/2017263002/diff/80001/cc/trees/property_tree....
cc/trees/property_tree.cc:1462: // the surface to the space of the surface
itself.
The comments really help, but this is a bit subtle and I was surprised that the
logic was specific to copy requests. I went on a quick search for similar code
elsewhere, but didn't find anything obviously the same (the closest I found was
UpdateTargetSpaceTransform).

Is there a chance that this code could eventually be shared, or is the copy
request scaling unique?

[ajuma, 2016-05-31 14:27:08]

https://codereview.chromium.org/2017263002/diff/80001/cc/trees/property_tree.cc
File cc/trees/property_tree.cc (right):

https://codereview.chromium.org/2017263002/diff/80001/cc/trees/property_tree....
cc/trees/property_tree.cc:1462: // the surface to the space of the surface
itself.
On 2016/05/31 01:47:12, vollick (ooo until May 16) wrote:
> The comments really help, but this is a bit subtle and I was surprised that
the
> logic was specific to copy requests. I went on a quick search for similar code
> elsewhere, but didn't find anything obviously the same (the closest I found
was
> UpdateTargetSpaceTransform).
> 
> Is there a chance that this code could eventually be shared, or is the copy
> request scaling unique?

I've updated this to call ComputeTransformWithDestinationSublayerScale to share
code a bit more. The more general idea of "put this rect into the space of this
surface" does seem like something that could eventually be shared with clip or
visible rect computation.

[Ian Vollick, 2016-05-31 14:59:23]

On 2016/05/31 14:27:08, ajuma wrote:
>
https://codereview.chromium.org/2017263002/diff/80001/cc/trees/property_tree.cc
> File cc/trees/property_tree.cc (right):
> 
>
https://codereview.chromium.org/2017263002/diff/80001/cc/trees/property_tree....
> cc/trees/property_tree.cc:1462: // the surface to the space of the surface
> itself.
> On 2016/05/31 01:47:12, vollick (ooo until May 16) wrote:
> > The comments really help, but this is a bit subtle and I was surprised that
> the
> > logic was specific to copy requests. I went on a quick search for similar
code
> > elsewhere, but didn't find anything obviously the same (the closest I found
> was
> > UpdateTargetSpaceTransform).
> > 
> > Is there a chance that this code could eventually be shared, or is the copy
> > request scaling unique?
> 
> I've updated this to call ComputeTransformWithDestinationSublayerScale to
share
> code a bit more. The more general idea of "put this rect into the space of
this
> surface" does seem like something that could eventually be shared with clip or
> visible rect computation.

Thanks, seems great. Still lgtm.

[ajuma, 2016-05-31 15:00:23]

The CQ bit was checked by ajuma@chromium.org

[commit-bot: I haz the power, 2016-05-31 15:00:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2017263002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2017263002/120001

[commit-bot: I haz the power, 2016-05-31 16:51:03]

Description was changed from

==========
cc: Move copy requests from layers to the effect tree

This makes the effect tree own copy requests. Clients still add copy
requests to individual Layers, but these are moved to the effect tree
at property-tree-building time, and then pushed with the effect tree
during commit and activation. This is a step towards removing the
dependency of RenderSurfaceImpls on their owning LayerImpl.

BUG=612208
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Move copy requests from layers to the effect tree

This makes the effect tree own copy requests. Clients still add copy
requests to individual Layers, but these are moved to the effect tree
at property-tree-building time, and then pushed with the effect tree
during commit and activation. This is a step towards removing the
dependency of RenderSurfaceImpls on their owning LayerImpl.

BUG=612208
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-05-31 16:51:04]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-05-31 16:52:34]

Description was changed from

==========
cc: Move copy requests from layers to the effect tree

This makes the effect tree own copy requests. Clients still add copy
requests to individual Layers, but these are moved to the effect tree
at property-tree-building time, and then pushed with the effect tree
during commit and activation. This is a step towards removing the
dependency of RenderSurfaceImpls on their owning LayerImpl.

BUG=612208
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Move copy requests from layers to the effect tree

This makes the effect tree own copy requests. Clients still add copy
requests to individual Layers, but these are moved to the effect tree
at property-tree-building time, and then pushed with the effect tree
during commit and activation. This is a step towards removing the
dependency of RenderSurfaceImpls on their owning LayerImpl.

BUG=612208
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc
Cr-Commit-Position: refs/heads/master@{#396848}
==========

[commit-bot: I haz the power, 2016-05-31 16:52:36]

Patchset 7 (id:??) landed as
https://crrev.com/e6f541bee0d43857dd85bb60479635d0c2810afc
Cr-Commit-Position: refs/heads/master@{#396848}