Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 201723003: Remove deprecated API for createAudioDevice. (Closed)

Created:
6 years, 9 months ago by KhNo
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove deprecated API for createAudioDevice. Blink is calling new API createAudioDevice(). It needs to remove. TODO(crogers): remove deprecated API as soon as WebKit calls new API. This patch is related with https://codereview.chromium.org/201303006/ BUG=353110 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169410

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M public/platform/Platform.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
KhNo
Please review the patch. :)
6 years, 9 months ago (2014-03-17 12:34:25 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-17 19:00:27 UTC) #2
KhNo
On 2014/03/17 19:00:27, abarth wrote: > lgtm Thank you.:)
6 years, 9 months ago (2014-03-17 23:46:11 UTC) #3
KhNo
The CQ bit was checked by keonho07.kim@samsung.com
6 years, 9 months ago (2014-03-18 02:30:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/201723003/1
6 years, 9 months ago (2014-03-18 03:19:31 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 04:12:36 UTC) #6
Message was sent while issue was closed.
Change committed as 169410

Powered by Google App Engine
This is Rietveld 408576698