Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2017213002: Implement DISALLOW_COPY_AND_ASSIGN using =delete, stage three. (Closed)

Created:
4 years, 6 months ago by Peter Kasting
Modified:
4 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement DISALLOW_COPY_AND_ASSIGN using =delete, stage three. This enables the new implementation all the time. BUG=447156 TEST=none TBR=thakis Committed: https://crrev.com/4bca3e6c230914f26c0d36ddb2c6e6cf89726c32 Cr-Commit-Position: refs/heads/master@{#396628}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M base/macros.h View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Peter Kasting
4 years, 6 months ago (2016-05-27 21:35:14 UTC) #2
Nico
On 2016/05/27 21:35:14, Peter Kasting wrote: Lgtm \o/
4 years, 6 months ago (2016-05-27 21:42:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017213002/1
4 years, 6 months ago (2016-05-27 23:25:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/78197)
4 years, 6 months ago (2016-05-28 01:10:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017213002/1
4 years, 6 months ago (2016-05-28 01:21:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-28 02:34:07 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-05-28 02:35:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4bca3e6c230914f26c0d36ddb2c6e6cf89726c32
Cr-Commit-Position: refs/heads/master@{#396628}

Powered by Google App Engine
This is Rietveld 408576698