Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 20172004: Split PepperPluginRegistry into the pieces that are needed in each process. content/common only nee… (Closed)

Created:
7 years, 5 months ago by jam
Modified:
7 years, 5 months ago
Reviewers:
scottmg
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Split PepperPluginRegistry into the pieces that are needed in each process. content/common only needed a simple method to get the list of pepper plugins. The zygote specific method moves to content/zygote. The rest moves to content/renderer, as that has dependencies on the pepper implementation which depends on blink. BUG=263054 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213593

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -491 lines) Patch
M content/browser/plugin_service_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M content/common/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
A content/common/pepper_plugin_list.h View 1 chunk +25 lines, -0 lines 0 comments Download
A content/common/pepper_plugin_list.cc View 1 chunk +112 lines, -0 lines 0 comments Download
D content/common/pepper_plugin_registry.h View 1 chunk +0 lines, -98 lines 0 comments Download
D content/common/pepper_plugin_registry.cc View 1 chunk +0 lines, -231 lines 0 comments Download
M content/content_common.gypi View 1 2 chunks +4 lines, -4 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
A + content/renderer/pepper/pepper_plugin_registry.h View 3 chunks +9 lines, -25 lines 0 comments Download
A + content/renderer/pepper/pepper_plugin_registry.cc View 3 chunks +5 lines, -121 lines 0 comments Download
M content/renderer/pepper/plugin_module.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/renderer_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 2 3 4 chunks +25 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
7 years, 5 months ago (2013-07-25 03:27:21 UTC) #1
scottmg
7 years, 5 months ago (2013-07-25 03:41:48 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698