Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2017123004: Revert of [tools/perf] Disable page_cycler_v2.typical_25 benchmark (Closed)

Created:
4 years, 6 months ago by nednguyen
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [tools/perf] Disable page_cycler_v2.typical_25 benchmark (patchset #1 id:1 of https://codereview.chromium.org/2013233002/ ) Reason for revert: Stack trace of crash should be enabled now. Reenable the benchmark to see what causes the failure. Original issue's description: > [tools/perf] Disable page_cycler_v2.typical_25 benchmark > > TBR=kouhei@chromium.org > BUG=615178 > > Committed: https://crrev.com/c84885e83ecac137b93ed2b6c8b7323d8e91ffe1 > Cr-Commit-Position: refs/heads/master@{#396337} TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=615178 Committed: https://crrev.com/997821c89eb567984eeea774934e955ddb4ec044 Cr-Commit-Position: refs/heads/master@{#396525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M tools/perf/benchmarks/page_cycler_v2.py View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
nednguyen
Created Revert of [tools/perf] Disable page_cycler_v2.typical_25 benchmark
4 years, 6 months ago (2016-05-27 18:55:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017123004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017123004/1
4 years, 6 months ago (2016-05-27 18:55:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 18:56:14 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 18:58:37 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/997821c89eb567984eeea774934e955ddb4ec044
Cr-Commit-Position: refs/heads/master@{#396525}

Powered by Google App Engine
This is Rietveld 408576698