Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2017073002: Revert of Roll PDFium 490d612..800222e (Closed)

Created:
4 years, 6 months ago by stevenjb
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, Oliver Chang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll PDFium 490d612..800222e (patchset #1 id:1 of https://codereview.chromium.org/2018903002/ ) Reason for revert: Compile failures on chromeos: https://build.chromium.org/p/chromiumos.chromium/builders/x86-generic-tot-chromium-pfq-informational/builds/8653/steps/BuildPackages/logs/stdio See comment for details. Original issue's description: > Roll PDFium 490d612..800222e > > https://pdfium.googlesource.com/pdfium.git/+log/490d612..800222e > > TBR=ochang@chromium.org > > Committed: https://crrev.com/7bc6fd9ed40bf5c02bf61d6c21bfd521e76cdd3d > Cr-Commit-Position: refs/heads/master@{#396419} TBR=ochang@chromium.org,thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/e2cbebae98114878d7a7c104670ccb1df12d0824 Cr-Commit-Position: refs/heads/master@{#396485}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
stevenjb
Created Revert of Roll PDFium 490d612..800222e
4 years, 6 months ago (2016-05-27 16:19:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017073002/1
4 years, 6 months ago (2016-05-27 16:19:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 16:20:21 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e2cbebae98114878d7a7c104670ccb1df12d0824 Cr-Commit-Position: refs/heads/master@{#396485}
4 years, 6 months ago (2016-05-27 16:21:55 UTC) #6
Lei Zhang
4 years, 6 months ago (2016-05-27 17:41:13 UTC) #7
Message was sent while issue was closed.
Double doh. LGTM.

Powered by Google App Engine
This is Rietveld 408576698