Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: third_party/WebKit/Source/core/testing/Internals.cpp

Issue 2017053003: Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/testing/Internals.cpp
diff --git a/third_party/WebKit/Source/core/testing/Internals.cpp b/third_party/WebKit/Source/core/testing/Internals.cpp
index 316059ea1783f887cfa5970dba2d052affdc853c..20d5a455ef40219487ada936fd63ceec9fa900e9 100644
--- a/third_party/WebKit/Source/core/testing/Internals.cpp
+++ b/third_party/WebKit/Source/core/testing/Internals.cpp
@@ -952,19 +952,19 @@ String Internals::viewportAsText(Document* document, float, int availableWidth,
StringBuilder builder;
- builder.appendLiteral("viewport size ");
+ builder.append("viewport size ");
builder.append(String::number(constraints.layoutSize.width()));
builder.append('x');
builder.append(String::number(constraints.layoutSize.height()));
- builder.appendLiteral(" scale ");
+ builder.append(" scale ");
builder.append(String::number(constraints.initialScale));
- builder.appendLiteral(" with limits [");
+ builder.append(" with limits [");
builder.append(String::number(constraints.minimumScale));
- builder.appendLiteral(", ");
+ builder.append(", ");
builder.append(String::number(constraints.maximumScale));
- builder.appendLiteral("] and userScalable ");
+ builder.append("] and userScalable ");
builder.append(description.userZoom ? "true" : "false");
return builder.toString();
@@ -2099,21 +2099,21 @@ String Internals::getCurrentCursorInfo()
Cursor cursor = frame()->page()->chromeClient().lastSetCursorForTesting();
StringBuilder result;
- result.appendLiteral("type=");
+ result.append("type=");
result.append(cursorTypeToString(cursor.getType()));
- result.appendLiteral(" hotSpot=");
+ result.append(" hotSpot=");
result.appendNumber(cursor.hotSpot().x());
result.append(',');
result.appendNumber(cursor.hotSpot().y());
if (cursor.getImage()) {
IntSize size = cursor.getImage()->size();
- result.appendLiteral(" image=");
+ result.append(" image=");
result.appendNumber(size.width());
result.append('x');
result.appendNumber(size.height());
}
if (cursor.imageScaleFactor() != 1) {
- result.appendLiteral(" scale=");
+ result.append(" scale=");
NumberToStringBuffer buffer;
result.append(numberToFixedPrecisionString(cursor.imageScaleFactor(), 8, buffer, true));
}
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGParsingError.cpp ('k') | third_party/WebKit/Source/core/xml/parser/XMLErrors.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698