third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp - Issue 2017053003: Remove StringBuilder::appendLiteral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp

Issue 2017053003: Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp b/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp

index efc257ab86983d8f5da6e5304816348ae830ef1b..09c2e5836bcb30d8d2d2abba45db0a6eeb168518 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp

@@ -190,9 +190,9 @@ std::unique_ptr<protocol::DictionaryValue> buildElementInfo(Element* element)

}

if (pseudoElement) {

if (pseudoElement->getPseudoId() == PseudoIdBefore)

- classNames.appendLiteral("::before");

+ classNames.append("::before");

else if (pseudoElement->getPseudoId() == PseudoIdAfter)

- classNames.appendLiteral("::after");

+ classNames.append("::after");

}

if (!classNames.isEmpty())

elementInfo->setString("className", classNames.toString());