Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: third_party/WebKit/Source/core/html/forms/FormController.cpp

Issue 2017053003: Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/forms/FormController.cpp
diff --git a/third_party/WebKit/Source/core/html/forms/FormController.cpp b/third_party/WebKit/Source/core/html/forms/FormController.cpp
index f9c01cbfea366990b64929b04ce68a4cd31d4da7..e28c74de0667c4fedec6f9f2d162cf2ef23f7748 100644
--- a/third_party/WebKit/Source/core/html/forms/FormController.cpp
+++ b/third_party/WebKit/Source/core/html/forms/FormController.cpp
@@ -312,7 +312,7 @@ static inline void recordFormStructure(const HTMLFormElement& form, StringBuilde
// 2 is enough to distinguish forms in webkit.org/b/91209#c0
const size_t namedControlsToBeRecorded = 2;
const FormAssociatedElement::List& controls = form.associatedElements();
- builder.appendLiteral(" [");
+ builder.append(" [");
for (size_t i = 0, namedControls = 0; i < controls.size() && namedControls < namedControlsToBeRecorded; ++i) {
if (!controls[i]->isFormControlElementWithState())
continue;
@@ -363,7 +363,7 @@ const AtomicString& FormKeyGenerator::formKey(const HTMLFormControlElementWithSt
StringBuilder formKeyBuilder;
formKeyBuilder.append(signature);
- formKeyBuilder.appendLiteral(" #");
+ formKeyBuilder.append(" #");
formKeyBuilder.appendNumber(nextIndex);
FormToKeyMap::AddResult addFormKeyresult = m_formToKeyMap.add(form, formKeyBuilder.toAtomicString());
return addFormKeyresult.storedValue->value;

Powered by Google App Engine
This is Rietveld 408576698