Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2029)

Unified Diff: third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp

Issue 2017053003: Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp
diff --git a/third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp b/third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp
index c04aa277c6c42410402192c67bea68f14dac9581..0981cb2cf304832b5e0ce8997fe88f69a95e259d 100644
--- a/third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp
+++ b/third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp
@@ -100,9 +100,9 @@ void StyledMarkupAccumulator::appendTextWithInlineStyle(Text& text, EditingStyle
DCHECK(!shouldAnnotate() || propertyMissingOrEqualToNone(inlineStyle->style(), CSSPropertyWebkitTextDecorationsInEffect));
DCHECK(m_document);
- m_result.appendLiteral("<span style=\"");
+ m_result.append("<span style=\"");
MarkupFormatter::appendAttributeValue(m_result, inlineStyle->style()->asText(), m_document->isHTMLDocument());
- m_result.appendLiteral("\">");
+ m_result.append("\">");
}
if (!shouldAnnotate()) {
appendText(text);
@@ -134,7 +134,7 @@ void StyledMarkupAccumulator::appendElementWithInlineStyle(StringBuilder& out, c
m_formatter.appendAttribute(out, element, attribute, nullptr);
}
if (style && !style->isEmpty()) {
- out.appendLiteral(" style=\"");
+ out.append(" style=\"");
MarkupFormatter::appendAttributeValue(out, style->style()->asText(), documentIsHTML);
out.append('\"');
}
@@ -162,9 +162,9 @@ void StyledMarkupAccumulator::wrapWithStyleNode(StylePropertySet* style)
DCHECK(m_document);
StringBuilder openTag;
- openTag.appendLiteral("<div style=\"");
+ openTag.append("<div style=\"");
MarkupFormatter::appendAttributeValue(openTag, style->asText(), m_document->isHTMLDocument());
- openTag.appendLiteral("\">");
+ openTag.append("\">");
m_reversedPrecedingMarkup.append(openTag.toString());
m_result.append("</div>");

Powered by Google App Engine
This is Rietveld 408576698