third_party/WebKit/Source/core/editing/Position.cpp - Issue 2017053003: Remove StringBuilder::appendLiteral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Position.cpp

Issue 2017053003: Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/Position.cpp

diff --git a/third_party/WebKit/Source/core/editing/Position.cpp b/third_party/WebKit/Source/core/editing/Position.cpp

index f1b0b81246eebfe59b8d808355ccadaf985b4f3d..d8e625438214f8f8f9782054af5a928346592003 100644

--- a/third_party/WebKit/Source/core/editing/Position.cpp

+++ b/third_party/WebKit/Source/core/editing/Position.cpp

@@ -594,12 +594,12 @@ void PositionTemplate<Strategy>::formatForDebugger(char* buffer, unsigned length

StringBuilder result;

if (isNull()) {

- result.appendLiteral("<null>");

+ result.append("<null>");

} else {

char s[1024];

- result.appendLiteral("offset ");

+ result.append("offset ");

result.appendNumber(m_offset);

- result.appendLiteral(" of ");

+ result.append(" of ");

anchorNode()->formatForDebugger(s, sizeof(s));

result.append(s);

}