Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 2017053003: Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | third_party/WebKit/Source/core/dom/Range.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Node.cpp
diff --git a/third_party/WebKit/Source/core/dom/Node.cpp b/third_party/WebKit/Source/core/dom/Node.cpp
index bdca7501b85e19f7ad25bb4b98438dc239679017..828076256d4def34015286d2f43aef31940b361d 100644
--- a/third_party/WebKit/Source/core/dom/Node.cpp
+++ b/third_party/WebKit/Source/core/dom/Node.cpp
@@ -1511,13 +1511,13 @@ String Node::debugName() const
if (isElementNode()) {
const Element& thisElement = toElement(*this);
if (thisElement.hasID()) {
- name.appendLiteral(" id=\'");
+ name.append(" id=\'");
name.append(thisElement.getIdAttribute());
name.append('\'');
}
if (thisElement.hasClass()) {
- name.appendLiteral(" class=\'");
+ name.append(" class=\'");
for (size_t i = 0; i < thisElement.classNames().size(); ++i) {
if (i > 0)
name.append(' ');
@@ -1576,9 +1576,9 @@ static void appendAttributeDesc(const Node* node, StringBuilder& stringBuilder,
return;
stringBuilder.append(attrDesc);
- stringBuilder.appendLiteral("=\"");
+ stringBuilder.append("=\"");
stringBuilder.append(attr);
- stringBuilder.appendLiteral("\"");
+ stringBuilder.append("\"");
}
void Node::showNode(const char* prefix) const
@@ -1604,9 +1604,9 @@ void Node::showNode(const char* prefix) const
appendAttributeDesc(this, attrs, classAttr, " CLASS");
appendAttributeDesc(this, attrs, styleAttr, " STYLE");
if (hasEditableStyle())
- attrs.appendLiteral(" (editable)");
+ attrs.append(" (editable)");
if (document().focusedElement() == this)
- attrs.appendLiteral(" (focused)");
+ attrs.append(" (focused)");
WTFLogAlways("%s%s\t%p%s\n", prefix, nodeName().utf8().data(), this, attrs.toString().utf8().data());
}
}
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | third_party/WebKit/Source/core/dom/Range.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698